linux-kernel - Re: [PATCH 2/2] powerpc/powernv: Reboot when requested by firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427693545.28219.1.camel@ellerman.id.au>
Date:	Mon, 30 Mar 2015 16:32:25 +1100
From:	Michael Ellerman <mpe@...erman.id.au>
To:	Joel Stanley <joel@....id.au>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	fabf@...net.be, akpm@...ux-foundation.org,
	benh@...nel.crashing.org, rusty@...tcorp.com.au, jk@...abs.org
Subject: Re: [PATCH 2/2] powerpc/powernv: Reboot when requested by firmware

On Mon, 2015-03-30 at 12:45 +1030, Joel Stanley wrote:
> Use orderly_reboot so userspace will to shut itself down via the reboot
> path. This is required for graceful reboot initiated by the BMC, such
> as when a user uses ipmitool to issue a 'chassis power cycle' command.
> 
> Signed-off-by: Joel Stanley <joel@....id.au>
> ---
>  arch/powerpc/platforms/powernv/opal-power.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/opal-power.c b/arch/powerpc/platforms/powernv/opal-power.c
> index 48bf5b0..ac46c2c 100644
> --- a/arch/powerpc/platforms/powernv/opal-power.c
> +++ b/arch/powerpc/platforms/powernv/opal-power.c
> @@ -29,8 +29,9 @@ static int opal_power_control_event(struct notifier_block *nb,
>  
>  	switch (type) {
>  	case SOFT_REBOOT:
> -		/* Fall through. The service processor is responsible for
> -		 * bringing the machine back up */
> +		pr_info("OPAL: reboot requested\n");
> +		orderly_reboot();
> +		break;

Acked-by: Michael Ellerman <mpe@...erman.id.au>


Andrew, do you want to take these 2 via your tree? Assuming folks are OK with
patch 1.

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/