linux-kernel - Re: [PATCH v6 1/4] perf,record: Add clockid parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5519CD1F.1000300@gmail.com>
Date:	Mon, 30 Mar 2015 16:24:31 -0600
From:	David Ahern <dsahern@...il.com>
To:	Stephane Eranian <eranian@...gle.com>, linux-kernel@...r.kernel.org
CC:	acme@...hat.com, peterz@...radead.org, mingo@...e.hu,
	ak@...ux.intel.com, jolsa@...hat.com, namhyung@...nel.org,
	cel@...ibm.com, sukadev@...ux.vnet.ibm.com, sonnyrao@...omium.org,
	johnmccutchan@...gle.com, adrian.hunter@...el.com,
	pawel.moll@....com
Subject: Re: [PATCH v6 1/4] perf,record: Add clockid parameter

On 3/30/15 4:19 PM, Stephane Eranian wrote:
> @@ -761,6 +762,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)
>   		attr->disabled = 0;
>   		attr->enable_on_exec = 0;
>   	}
> +
> +	if (opts->clockid >= 0) {
> +		attr->use_clockid = 1;
> +		attr->clockid = opts->clockid;
> +	} else
> +		attr->clockid = -1;
>   }

The else part needs to be removed (can't set clockid to -1). And then ...

> diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
> index fb43215..164441a 100644
> --- a/tools/perf/util/header.c
> +++ b/tools/perf/util/header.c
> @@ -1098,6 +1098,8 @@ static void print_event_desc(struct perf_header *ph, int fd, FILE *fp)
>   			}
>   			fprintf(fp, " }");
>   		}
> +		fprintf(fp, ", clockid = %d", evsel->attr.clockid);
> +

this should be prefaced with:

     if (evsel->attr.use_clockid)

(use_clockid bit says whether the clockid value was set)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/