linux-kernel - Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"peakup@...ux-speakup.org,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150330070903.GA27688@pwitoslawski.warsaw.osa>
Date:	Mon, 30 Mar 2015 09:09:03 +0200
From:	Piotr Witosławski <pwitos@...il.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	William Hubbs <w.d.hubbs@...il.com>,
	Chris Brannon <chris@...-brannons.com>,
	Kirk Reiser <kirk@...sers.ca>,
	Samuel Thibault <samuel.thibault@...-lyon.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	speakup@...ux-speakup.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] drivers: staging: speakup: fix sparse "warning:
 expression using sizeof bool"peakup@...ux-speakup.org,

On Mon, Mar 30, 2015 at 11:49:53AM +0530, Sudip Mukherjee wrote:
> On Sat, Mar 28, 2015 at 08:57:01AM +0100, Piotr Witosławski wrote:
> > On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote:
> > > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote:
> > > > Changed bool to u8 to get rid of sparse warning.
> > > but i am not getting this warning. which version of sparse are you
> > > using?
> > 
> > sparse 0.5.0, see: http://yarchive.net/comp/linux/bool.html
> looks like you have done quite a lot of research on it .. :)
> i am using 0.5.0-22-gd92353b, and my sparse is not showing me this
> warning.

Checked it on the git source, it was moved from default
to the -Wsizeof-bool flag with commit: 2667c2d4ab3342b54283d16f1d62e6d715f3b373.
That's why I got the warning and you didn't. If you turn on this flag,
you'll get it. It's not really anything important, I'm doing a patch for the
eudyptula-challange, if you don't accept it, I'll find sth else in
drivers/staging.

> 
> regards
> sudip
> > 
> > > and why you have sent the same patch two times?
> > 
> > sorry my mistake, first time I wanted send it to myself, I forgot
> > that I filled CC list. 
> > 
> > > 
> > > regards
> > > sudip
> > > 
> > > > 
> > > > Signed-off-by: Piotr Witoslawski <pwitos@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/