linux-kernel - Re: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit get/set time methods.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150331213707.GA9139@localhost.localdomain>
Date:	Tue, 31 Mar 2015 23:37:07 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	"Keller, Jacob E" <jacob.e.keller@...el.com>
Cc:	"thomas.lendacky@....com" <thomas.lendacky@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"baolin.wang@...aro.org" <baolin.wang@...aro.org>,
	"b45643@...escale.com" <b45643@...escale.com>,
	"sshah@...arflare.com" <sshah@...arflare.com>,
	"amirv@...lanox.com" <amirv@...lanox.com>,
	"ben@...adent.org.uk" <ben@...adent.org.uk>,
	"sonic.zhang@...log.com" <sonic.zhang@...log.com>,
	"peppe.cavallaro@...com" <peppe.cavallaro@...com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"rayagond@...avyalabs.com" <rayagond@...avyalabs.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"ariel.elior@...gic.com" <ariel.elior@...gic.com>,
	"cmetcalf@...hip.com" <cmetcalf@...hip.com>,
	"Vick, Matthew" <matthew.vick@...el.com>,
	"linux-net-drivers@...arflare.com" <linux-net-drivers@...arflare.com>,
	"arnd@...aro.org" <arnd@...aro.org>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"mchan@...adcom.com" <mchan@...adcom.com>,
	"Wyborny, Carolyn" <carolyn.wyborny@...el.com>,
	"prashant@...adcom.com" <prashant@...adcom.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"stefan.sorensen@...ctralink.com" <stefan.sorensen@...ctralink.com>,
	"john.stultz@...aro.org" <john.stultz@...aro.org>
Subject: Re: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit
 get/set time methods.

On Tue, Mar 31, 2015 at 09:08:10PM +0000, Keller, Jacob E wrote:
> On Sun, 2015-03-29 at 23:12 +0200, Richard Cochran wrote:
> > For the 82576, the driver's clock is implemented using a timecounter,
> > and so with this patch that device is ready for the year 2038.
> > 
> > However, in the case of the i210, the device stores the number of
> > seconds in a 32 bit register.  Therefore, more work is needed on this
> > driver before the year 2038 comes around.
> > 
> > Compile tested only.
> 
> I assume we would want to use a time counter wrapper here to resolve
> this issue?

I would just keep the seconds in software for settime() and adjtime(),
but let the nanoseconds field go to the hardware.  Then, the gettime()
result, the periodic outputs, the external time stamps, and the skb
time stamps will need to be corrected by that many seconds.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/