linux-kernel - Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABxcv=moU4xO=BNj6r4_O-VeL_OuAjCuoWiB9xsKWw9NjFTr9g@mail.gmail.com>
Date:	Tue, 31 Mar 2015 08:37:55 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Chanwoo Choi <cw00.choi@...sung.com>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Markus Reichl <m.reichl@...etechno.de>
Subject: Re: [PATCH] ARM: dts: Use define for s3c-rtc clock id

On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
> Hi,
>
> On 03/31/2015 12:21 AM, Krzysztof Kozlowski wrote:
>> Use a define instead of raw number as a ID for "rtc_src" clock.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com>
>>
>> ---
>>
>> Patch depends on new file "dt-bindings/clock/samsung,s2mps11.h" from:
>> http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg43136.html
>> ---
>>  arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
>> index 3905824cac58..d2cbc95364de 100644
>> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
>> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
>> @@ -16,6 +16,7 @@
>>  #include "exynos3250.dtsi"
>>  #include <dt-bindings/input/input.h>
>>  #include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/clock/samsung,s2mps11.h>
>>
>>  / {
>>       model = "Samsung Rinato board";
>> @@ -605,7 +606,7 @@
>>  };
>>
>>  &rtc {
>> -     clocks = <&cmu CLK_RTC>, <&s2mps14_osc 0>;
>> +     clocks = <&cmu CLK_RTC>, <&s2mps14_osc S2MPS11_CLK_AP>;
>>       clock-names = "rtc", "rtc_src";
>>       status = "okay";
>>  };
>>
>
> Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>
>

Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/