linux-kernel - Re: [PATCH v2] btrfs: explicitly set control file's private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ7vePA5CpzVSPwHD6X4arLPRLt9tdgXSVAcQtyugJporJG-ng@mail.gmail.com>
Date:	Tue, 31 Mar 2015 14:31:37 +0200
From:	Tom Van Braeckel <tomvanbraeckel@...il.com>
To:	Chris Mason <clm@...com>, jbacik@...com, dsterba@...e.cz,
	linux-btrfs@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org,
	Tom Van Braeckel <tomvanbraeckel@...il.com>,
	Martin Kepplinger <martink@...teo.de>
Subject: Re: [PATCH v2] btrfs: explicitly set control file's private_data

Err, upon further inspection, I think that this was a false positive.

Btrfs relies on the initial value of the private_data member of a file
being NULL in the regular ioctl operation handler for
BTRFS_IOC_TRANS_START but it does not use the miscdevice framework for
those files.

It *does* use the miscdevice framework in the ioctl operation handler
of the /dev/btrfs-control file but there it does not use the file's
private_data member. So IMHO, the proposed patch is not necessary...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/