linux-kernel - Re: [PATCH v3 2/2] perf tool: Fix ppid for synthesized fork events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150331141026.GC3777@krava.brq.redhat.com>
Date:	Tue, 31 Mar 2015 16:10:26 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	David Ahern <dsahern@...il.com>
Cc:	acme@...nel.org, linux-kernel@...r.kernel.org,
	Don Zickus <dzickus@...hat.com>, Joe Mario <jmario@...hat.com>
Subject: Re: [PATCH v3 2/2] perf tool: Fix ppid for synthesized fork events

On Mon, Mar 30, 2015 at 02:35:58PM -0600, David Ahern wrote:
> 363b785f38 added synthesized fork events and set a thread's parent id
> to itself. Since we are already processing /proc/<pid>/status the ppid
> can be determined properly. Make it so.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> Cc: Don Zickus <dzickus@...hat.com>
> Cc: Joe Mario <jmario@...hat.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> ---
> v3
> - removed isspace and newline checks; added brackets per Arnaldo's comments
> 
> v2:
> - removed changes to function signature for perf_event__synthesize_comm as
>   noted by Jiri
> 
>  tools/perf/util/event.c | 83 +++++++++++++++++++++++++++++--------------------
>  1 file changed, 50 insertions(+), 33 deletions(-)
> 
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index 023dd3548a94..5516236df6ab 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -51,29 +51,32 @@ static struct perf_sample synth_sample = {
>  
>  /*
>   * Assumes that the first 4095 bytes of /proc/pid/stat contains
> - * the comm and tgid.
> + * the comm, tgid and ppid.
>   */
> -static pid_t perf_event__get_comm_tgid(pid_t pid, char *comm, size_t len)
> +static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
> +				    pid_t *tgid, pid_t *ppid)
>  {
>  	char filename[PATH_MAX];
>  	char bf[4096];
>  	int fd;
>  	size_t size = 0, n;
> -	pid_t tgid = -1;
> -	char *nl, *name, *tgids;
> +	char *nl, *name, *tgids, *ppids;
> +
> +	*tgid = -1;
> +	*ppid = -1;
>  
>  	snprintf(filename, sizeof(filename), "/proc/%d/status", pid);
>  
>  	fd = open(filename, O_RDONLY);
>  	if (fd < 0) {
>  		pr_debug("couldn't open %s\n", filename);
> -		return 0;
> +		return -1;

hum, missed this one in previous version.. why did not we fail before?

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/