linux-kernel - Re: [PATCH] ti-soc-thermal: implement omap3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANOLnOO4J3RQCJZB0ibkGc5KhvPu+Q1f-bwc8mpxKCPRgjw5PQ@mail.gmail.com>
Date:	Tue, 31 Mar 2015 18:02:54 +0300
From:	Grazvydas Ignotas <notasas@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Pali Rohar <pali.rohar@...il.com>, sre@...ian.org, sre@...g0.de,
	kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>, khilman@...nel.org,
	Aaro Koskinen <aaro.koskinen@....fi>,
	ivo.g.dimitrov.75@...il.com, edubezval@...il.com,
	rui.zhang@...el.com, linux-pm@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] ti-soc-thermal: implement omap3 support

On Tue, Mar 31, 2015 at 11:42 AM, Pavel Machek <pavel@....cz> wrote:
>
> This adds support for OMAP3 chips to ti-soc-thermal. As requested by
> TI people, it is marked unreliable and warning is printed.
>
> Signed-off-by: Pavel Machek <pavel@....cz>
>
> ---
> ...
> --- /dev/null
> +++ b/drivers/thermal/ti-soc-thermal/omap3-thermal-data.c
> @@ -0,0 +1,103 @@
> +/*
> + * OMAP3 thermal driver.
> + *
> + * Copyright (C) 2011-2012 Texas Instruments Inc.
> + * Copyright (C) 2014 Pavel Machek <pavel@....cz>
> + *
> + * This software is licensed under the terms of the GNU General Public
> + * License version 2, as published by the Free Software Foundation, and
> + * may be copied, distributed, and modified under those terms.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * Note
> + * http://www.ti.com/lit/er/sprz278f/sprz278f.pdf "Advisory
> + * 3.1.1.186 MMC OCP Clock Not Gated When Thermal Sensor Is Used"
> + *
> + * Also TI says:
> + * Just be careful when you try to make thermal policy like decisions
> + * based on this sensor. Placement of the sensor w.r.t the actual logic
> + * generating heat has to be a factor as well. If you are just looking
> + * for an approximation temperature (thermometerish kind), you might be
> + * ok with this. I am not sure we'd find any TI data around this.. just a
> + * heads up.
> + */
> +
> +#include "ti-thermal.h"
> +#include "ti-bandgap.h"
> +
> +/*
> + * OMAP34XX has one instance of thermal sensor for MPU
> + * need to describe the individual bit fields
> + */
> +static struct temp_sensor_registers
> +omap34xx_mpu_temp_sensor_registers = {
> +       .temp_sensor_ctrl = 0,
> +       .bgap_soc_mask = BIT(8),
> +       .bgap_eocz_mask = BIT(7),
> +       .bgap_dtemp_mask = 0x7f,
> +
> +       .bgap_mode_ctrl = 0,
> +       .mode_ctrl_mask = BIT(9),
> +};
> +
> +/* Thresholds and limits for OMAP34XX MPU temperature sensor */
> +static struct temp_sensor_data omap34xx_mpu_temp_sensor_data = {
> +       .min_freq = 32768,
> +       .max_freq = 32768,
> +       .max_temp = -99000,
> +       .min_temp = 99000,

This looks mixed up. Also, perhaps use -40000 to 125000 to match the
table below?

> +       .hyst_val = 5000,
> +};
> +
> +/*
> + * Temperature values in milli degree celsius
> + */
> +static const int
> +omap34xx_adc_to_temp[128] = {
> +       -40000, -40000, -40000, -40000, -40000, -39000, -38000, -36000,
> +       -34000, -32000, -31000, -29000, -28000, -26000, -25000, -24000,
> +       -22000, -21000, -19000, -18000, -17000, -15000, -14000, -12000,
> +       -11000, -9000, -8000, -7000, -5000, -4000, -2000, -1000, 0000,
> +       1000, 3000, 4000, 5000, 7000, 8000, 10000, 11000, 13000, 14000,
> +       15000, 17000, 18000, 20000, 21000, 22000, 24000, 25000, 27000,
> +       28000, 30000, 31000, 32000, 34000, 35000, 37000, 38000, 39000,
> +       41000, 42000, 44000, 45000, 47000, 48000, 49000, 51000, 52000,
> +       53000, 55000, 56000, 58000, 59000, 60000, 62000, 63000, 65000,
> +       66000, 67000, 69000, 70000, 72000, 73000, 74000, 76000, 77000,
> +       79000, 80000, 81000, 83000, 84000, 85000, 87000, 88000, 89000,
> +       91000, 92000, 94000, 95000, 96000, 98000, 99000, 100000,
> +       102000, 103000, 105000, 106000, 107000, 109000, 110000, 111000,
> +       113000, 114000, 116000, 117000, 118000, 120000, 121000, 122000,
> +       124000, 124000, 125000, 125000, 125000, 125000, 125000
> +};
>

Gražvydas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/