linux-kernel - Re: [PATCH v2 1/2] perf tool: Refactor comm/tgid lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150331155557.GK9438@kernel.org>
Date:	Tue, 31 Mar 2015 12:55:57 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	David Ahern <dsahern@...il.com>, linux-kernel@...r.kernel.org,
	Don Zickus <dzickus@...hat.com>, Joe Mario <jmario@...hat.com>
Subject: Re: [PATCH v2 1/2] perf tool: Refactor comm/tgid lookup

Em Tue, Mar 31, 2015 at 04:35:46PM +0200, Jiri Olsa escreveu:
> On Mon, Mar 30, 2015 at 02:35:57PM -0600, David Ahern wrote:
> > Rather than parsing /proc/pid/status file one line at a time, read
> > it into a buffer in one shot and search for all strings in one pass.
> > 
> > tgid conversion also simplified -- removing the isspace walk. As
> > noted by Arnaldo those are not needed for atoi == strtol calls.
> > 
> > Signed-off-by: David Ahern <dsahern@...il.com>
> > Cc: Don Zickus <dzickus@...hat.com>
> > Cc: Joe Mario <jmario@...hat.com>
> > Cc: Jiri Olsa <jolsa@...hat.com>
> 
> Acked-by: Jiri Olsa <jolsa@...nel.org>

Thanks, applied both, with Jiri's acks.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/