linux-kernel - Re: [PATCH 1/2] phy: spear1310-miphy: Return proper error for spear1310_miphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <551AC69E.3050407@ti.com>
Date:	Tue, 31 Mar 2015 21:39:02 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Axel Lin <axel.lin@...ics.com>
CC:	Pratyush Anand <pratyush.anand@...com>,
	Peter Griffin <peter.griffin@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] phy: spear1310-miphy: Return proper error for spear1310_miphy_xlate

Hi,

On Wednesday 25 March 2015 02:31 PM, Axel Lin wrote:
> The of_xlate callback should return ERR_PTR on error.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>   drivers/phy/phy-spear1310-miphy.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-spear1310-miphy.c b/drivers/phy/phy-spear1310-miphy.c
> index 9f47fae..4684b04 100644
> --- a/drivers/phy/phy-spear1310-miphy.c
> +++ b/drivers/phy/phy-spear1310-miphy.c
> @@ -192,14 +192,14 @@ static struct phy *spear1310_miphy_xlate(struct device *dev,
>
>   	if (args->args_count < 1) {
>   		dev_err(dev, "DT did not pass correct no of args\n");
> -		return NULL;
> +		return ERR_PTR(-EINVAL);

It should actually be -ENODEV so that phy_optional_get() doesn't fail.
>   	}
>
>   	priv->mode = args->args[0];
>
>   	if (priv->mode != SATA && priv->mode != PCIE) {
>   		dev_err(dev, "DT did not pass correct phy mode\n");
> -		return NULL;
> +		return ERR_PTR(-EINVAL);

Same here.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/