lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Mar 2015 09:27:53 -0700 From: Kevin Hilman <khilman@...nel.org> To: Sascha Hauer <s.hauer@...gutronix.de> Cc: linux-arm-kernel@...ts.infradead.org, Matthias Brugger <matthias.bgg@...il.com>, devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, kernel@...gutronix.de Subject: Re: [PATCH 2/4] soc: Mediatek: Add SCPSYS power domain driver Hi Sascha, Sascha Hauer <s.hauer@...gutronix.de> writes: > This adds a power domain driver for the Mediatek SCPSYS unit. > > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. The tasks include thermal > measurement, dynamic voltage frequency scaling (DVFS), interrupt > filter and lowlevel sleep control. The System Power Manager (SPM) > inside the SCPSYS is for the MTCMOS power domain control. > > For now this driver only adds power domain support, the more > advanced features are not yet supported. The driver implements > the generic PM domain device tree bindings, the first user will > most likely be the Mediatek AFE audio driver. > > Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de> Sorry for the lag, was travelling last week at ELC and not keeping up with reviews. This version looks pretty good to me, but had one minor comment/question... [...] > +#define NUM_DOMAINS ARRAY_SIZE(scp_domain_data) > + > +struct scp; > + > +struct scp_domain { > + struct generic_pm_domain pmd; > + struct scp_domain_data *data; > + struct scp *scp; > +}; > + > +struct scp { > + struct scp_domain domains[NUM_DOMAINS]; > + struct generic_pm_domain *pmd[NUM_DOMAINS]; Why is this genpd pointer needed? It's just a pointer to the .domains.pmd[i] anyways, and IMO makes the code a bit hard to follow. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists