linux-kernel - Re: [PATCH_V3 0/2] mtd: nand: jz4780: Add nand and bch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150331172030.GE19571@brian-ubuntu>
Date:	Tue, 31 Mar 2015 10:20:30 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>
Cc:	dwmw2@...radead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: Re: [PATCH_V3 0/2] mtd: nand: jz4780: Add nand and bch driver

On Tue, Mar 31, 2015 at 05:59:39PM +0100, Zubair Lutfullah Kakakhel wrote:
> Hi,

Hi!

Nit: can you drop the underscore in your 'PATCH_Vx' subjects? It'd make
my filtering a bit easier. I usually expect 'PATCH v3'. Thanks!

> Two patches based on 4.0-rc6 that add NAND and BCH controller
> drivers for the Ingenic JZ4780 SoC.
> 
> Hope these can make it in time for 4.1.
> 
> Tested on the MIPS Creator CI20.
> 
> Core JZ4780 support is still in-flight.

Sorry, I can't even compile test your patches, since I don't have the
dependencies. So I can't accept your patches yet, and they most likely
won't make it to 4.1. Or if you can point me to the right place, perhaps
we can work something out between the tree(s) that will contain the
dependencies.

Note that I'm not worried about the missing MACH_JZ4780 sybmol and your
core platform support, as much as the missing JZ4780_NEMC support.

> Review and feedback welcome.
> 
> V2 - > V3
> Rebase to 4.0-rc6
> Binding changes and fixes based on feedback by Brian Norris (Thank-you)

I had a few questions on the driver that you didn't answer, I believe.
It looks like maybe you silently answered them in this v3 code?

> V1 - > V2
> Fixed module license macros
> Rebase to 4.0-rc3
> 
> Thanks,
> ZubairLK
> 
> Alex Smith (2):
>   dt-bindings: binding for jz4780-{nand,bch}
>   mtd: nand: jz4780: driver for NAND devices on JZ4780 SoCs
> 
>  .../bindings/mtd/ingenic,jz4780-nand.txt           |  57 ++++
>  drivers/mtd/nand/Kconfig                           |   7 +
>  drivers/mtd/nand/Makefile                          |   1 +
>  drivers/mtd/nand/jz4780_bch.c                      | 353 +++++++++++++++++++
>  drivers/mtd/nand/jz4780_bch.h                      |  42 +++
>  drivers/mtd/nand/jz4780_nand.c                     | 376 +++++++++++++++++++++
>  6 files changed, 836 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt
>  create mode 100644 drivers/mtd/nand/jz4780_bch.c
>  create mode 100644 drivers/mtd/nand/jz4780_bch.h
>  create mode 100644 drivers/mtd/nand/jz4780_nand.c
> 

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/