linux-kernel - Re: [PATCH 1/7] lib/vsprintf: add %*pg format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427823434.10376.33.camel@perches.com>
Date:	Tue, 31 Mar 2015 10:37:14 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	axboe@...nel.dk, viro@...iv.linux.org.uk, dm-devel@...hat.com
Subject: Re: [PATCH 1/7] lib/vsprintf: add %*pg format specifier

On Tue, 2015-03-31 at 10:06 -0700, Joe Perches wrote:
> On Tue, 2015-03-31 at 20:01 +0400, Dmitry Monakhov wrote:
> > This allow to directly print block_device name.
> > Currently one should use bdevname() with temporal char buf[BDEVNAME_SIZE].
> > This is very ineffective because bloat stack usage for deep IO call-traces

Perhaps it would be useful to update the disk_name/bdevname
functions to take a buffer length along with the char * so
that buffer overflows could not occur.

That would also allow this function to use bdevname directly.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/