linux-kernel - Re: [PATCH] powerpc/83xx: add support for mpc8306

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Mar 2015 12:54:53 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Filip Brozovic <fbrozovic@...il.com>
CC:	<galak@...nel.crashing.org>, <benh@...nel.crashing.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc/83xx: add support for mpc8306

On Sat, 2015-03-28 at 17:59 +0100, Filip Brozovic wrote:
> diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
> index c2518cd..f967ff6 100644
> --- a/arch/powerpc/sysdev/qe_lib/qe.c
> +++ b/arch/powerpc/sysdev/qe_lib/qe.c
> @@ -278,12 +278,17 @@ static void qe_snums_init(void)
>  		0xF4, 0xF5, 0xFC, 0xFD,
>  	};
>  	static const u8 snum_init_46[] = {
> +#if !defined(CONFIG_QE_8306)
>  		0x04, 0x05, 0x0C, 0x0D, 0x14, 0x15, 0x1C, 0x1D,
> -		0x24, 0x25, 0x2C, 0x2D, 0x34, 0x35, 0x88, 0x89,
> -		0x98, 0x99, 0xA8, 0xA9, 0xB8, 0xB9, 0xC8, 0xC9,
> -		0xD8, 0xD9, 0xE8, 0xE9, 0x08, 0x09, 0x18, 0x19,
> -		0x28, 0x29, 0x38, 0x39, 0x48, 0x49, 0x58, 0x59,
> -		0x68, 0x69, 0x78, 0x79, 0x80, 0x81,
> +		0x24, 0x25, 0x2C, 0x2D, 0x34, 0x35,
> +#endif
> +		0x88, 0x89, 0x98, 0x99, 0xA8, 0xA9, 0xB8, 0xB9,
> +		0xC8, 0xC9, 0xD8, 0xD9, 0xE8, 0xE9,
> +#if !defined(CONFIG_QE_8306)
> +		0x08, 0x09, 0x18, 0x19, 0x28, 0x29, 0x38, 0x39,
> +		0x48, 0x49, 0x58, 0x59, 0x68, 0x69, 0x78, 0x79,
> +		0x80, 0x81,
> +#endif
>  	};
>  	static const u8 *snum_init;

This breaks multiplatform support.  You need to determine this at
runtime.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/