linux-kernel - Re: linux-next: build warning after merge of the char-misc tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Mar 2015 21:35:45 +0200 (CEST)
From:	Fabian Frederick <fabf@...net.be>
To:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Arnd Bergmann <arnd@...db.de>, Greg KH <greg@...ah.com>
Cc:	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: Re: linux-next: build warning after merge of the char-misc tree



> On 27 March 2015 at 08:48 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
>
> Hi all,
>
> After merging the char-misc tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> In file included from include/linux/module.h:17:0,
>                  from drivers/uio/uio_pdrv_genirq.c:21:
> include/linux/moduleparam.h:326:22: warning: initialization discards 'const'
> qualifier from pointer target type
>   static const struct kparam_string __param_string_##name  \
>                       ^
> drivers/uio/uio_pdrv_genirq.c:260:1: note: in expansion of macro
> 'module_param_string'
>  module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
>  ^
>
> Introduced by commit 4d8beff2ae07 ("uio: constify of_device_id array").

Hi Stephen,

Absolutely, my patch is wrong ; comment below explains struct is filled
afterwards.Sorry.
Greg, should I send you a revert or maybe we could standardize that driver ? (it
seems it's the only one to work that way).

static const struct of_device_id uio_of_genirq_match[] = {
        { /* This is filled with module_parm */ },
        { /* Sentinel */ },
};

Regards,
Fabian

> --
> Cheers,
> Stephen Rothwell                    sfr@...b.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/