linux-kernel - Re: [PATCH 1/2] kernel/reboot.c: Add orderly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150331220326.994661ba.akpm@linux-foundation.org>
Date:	Tue, 31 Mar 2015 22:03:26 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Anshuman Khandual <khandual@...ux.vnet.ibm.com>
Cc:	Joel Stanley <joel@....id.au>, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, rusty@...tcorp.com.au,
	fabf@...net.be, jk@...abs.org
Subject: Re: [PATCH 1/2] kernel/reboot.c: Add orderly_reboot for graceful
 reboot

On Wed, 01 Apr 2015 10:22:08 +0530 Anshuman Khandual <khandual@...ux.vnet.ibm.com> wrote:

> >  char poweroff_cmd[POWEROFF_CMD_PATH_LEN] = "/sbin/poweroff";
> > +char reboot_cmd[POWEROFF_CMD_PATH_LEN] = "/sbin/reboot";
> 
> Should not we declare one more REBOOT_CMD_PATH_LEN to make it cleaner.

It doesn't really seem necessary - they'll have the same value anyway.

But if you aren't going to implement the sysctl it isn't needed at all -
just do

static char reboot_cmd[] = "/sbin/reboot";

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/