linux-kernel - Re: [PATCH 19/25] sched: Use bool function return values of true/false not 1/0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGQ1y=5742GKZx7YWOMnD+wuVy7zX=sirUYVipHYw7fzjP66xw@mail.gmail.com>
Date:	Tue, 31 Mar 2015 22:17:34 -0700
From:	Jason Low <jason.low2@...com>
To:	Joe Perches <joe@...ches.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 19/25] sched: Use bool function return values of
 true/false not 1/0

On Mon, Mar 30, 2015 at 4:46 PM, Joe Perches <joe@...ches.com> wrote:

>   *     try_wait_for_completion - try to decrement a completion without blocking
>   *     @x:     completion structure
>   *
> - *     Return: 0 if a decrement cannot be done without blocking
> - *              1 if a decrement succeeded.
> + *     Return: true if a decrement cannot be done without blocking
> + *             false if a decrement succeeded.

Hi Joe,

The boolean logic was reversed in this comment. The function should be
returning false if a decrement cannot be done without blocking, and
true if a decrement succeeded.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/