linux-kernel - Re: [PATCH 2/9] perf sched replay: Increase the MAX_PID value to fix assertion failure problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551B99E8.9060205@huawei.com>
Date:	Wed, 1 Apr 2015 15:10:32 +0800
From:	Yunlong Song <yunlong.song@...wei.com>
To:	David Ahern <dsahern@...il.com>, <a.p.zijlstra@...llo.nl>,
	<paulus@...ba.org>, <mingo@...hat.com>, <acme@...nel.org>
CC:	<linux-kernel@...r.kernel.org>, <wangnan0@...wei.com>
Subject: Re: [PATCH 2/9] perf sched replay: Increase the MAX_PID value to
 fix assertion failure problem

On 2015/3/31 22:25, David Ahern wrote:
> On 3/31/15 7:46 AM, Yunlong Song wrote:
>> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
>> index a1893e8..c466104 100644
>> --- a/tools/perf/builtin-sched.c
>> +++ b/tools/perf/builtin-sched.c
>> @@ -28,7 +28,7 @@
>>   #define MAX_CPUS        4096
>>   #define COMM_LEN        20
>>   #define SYM_LEN            129
>> -#define MAX_PID            65536
>> +#define MAX_PID            1024000
>>
>>   struct sched_atom;
> 
> # cat /proc/sys/kernel/pid_max
> 1048576
> 
> so your proposed change is still not high enough for what I need.
> 
> It would be best to make it dynamic, not static, with run time reallocations as needed.
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
Yes, please see my 3rd and 4th patch in the patch sets, which dynamic allocate the memory
in run time.

-- 
Thanks,
Yunlong Song

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/