linux-kernel - Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551BC2E2.9040007@citrix.com>
Date:	Wed, 1 Apr 2015 11:05:22 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Bob Liu <bob.liu@...cle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	<jennifer.herbert@...rix.com>, <linux-kernel@...r.kernel.org>,
	<david.vrabel@...rix.com>, <xen-devel@...ts.xenproject.org>,
	<boris.ostrovsky@...cle.com>,
	Roger Pau Monné <roger.pau@...rix.com>
Subject: Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion()

On 30/03/15 01:03, Bob Liu wrote:
> 
> On 03/28/2015 08:44 AM, Konrad Rzeszutek Wilk wrote:
>> On Thu, Mar 26, 2015 at 04:32:45PM +0100, Roger Pau Monné wrote:
>>> El 26/03/15 a les 13.16, Bob Liu ha escrit:
>>>> There are several place using gnttab async unmap and wait for
>>>> completion, so move the common code to a function
>>>> gnttab_unmap_refs_async_wait_completion().
>>>>
>>>> Signed-off-by: Bob Liu <bob.liu@...cle.com>
>>>
>>> For the blkback parts:
>>>
>>> Acked-by: Roger Pau Monné <roger.pau@...rix.com>
>>>
>>> Although, as David already said, I think we should do better than BUG_ON
>>> on error.
>>
> 
> This patch only keeps the existing behaviour the same as before. I
> prefer to make new patches(based on this one) if want to change the
> behaviour.
> 
>> Have an 'stuck deferred pages' list and an timer to occasionally
>> flush them out? Something similar to 569ca5b3f94cd0b3295ec5943aa457cf4a4f6a3a
>> "xen/gnttab: add deferred freeing logic" ?
> 
> Sounds like a good idea.

If it failed the first time I don't see how it would succeed later.  No
one has actually hit this particular BUG_ON() so I would leave it as is.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/