linux-kernel - Re: [virtio-dev] [PATCH v3 3/6] virtio_ccw: support non-legacy balloon devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551BCB0A.4060107@de.ibm.com>
Date:	Wed, 01 Apr 2015 12:40:10 +0200
From:	Christian Borntraeger <borntraeger@...ibm.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>, linux-kernel@...r.kernel.org
CC:	Cornelia Huck <cornelia.huck@...ibm.com>,
	Pawel Moll <pawel.moll@....com>,
	virtio-dev@...ts.oasis-open.org, linux390@...ibm.com,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-s390@...r.kernel.org
Subject: Re: [virtio-dev] [PATCH v3 3/6] virtio_ccw: support non-legacy balloon
 devices

Am 01.04.2015 um 12:35 schrieb Michael S. Tsirkin:
> virtio_device_is_legacy_only is always false now,
> drop the test from virtio ccw.

Can you add the commit subject of patch2 here as a
prereq for this patch? This will hopefully avoid 
backport issues on distros that want to take this
patch but not the other for whatever reasons.


this patch is then.
Reviewed-by: Christian Borntraeger <borntraeger@...ibm.com>


> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
> ---
>  drivers/s390/kvm/virtio_ccw.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
> index 71d7802..6f1fa17 100644
> --- a/drivers/s390/kvm/virtio_ccw.c
> +++ b/drivers/s390/kvm/virtio_ccw.c
> @@ -1201,13 +1201,9 @@ static int virtio_ccw_online(struct ccw_device *cdev)
>  	vcdev->vdev.id.vendor = cdev->id.cu_type;
>  	vcdev->vdev.id.device = cdev->id.cu_model;
> 
> -	if (virtio_device_is_legacy_only(vcdev->vdev.id)) {
> -		vcdev->revision = 0;
> -	} else {
> -		ret = virtio_ccw_set_transport_rev(vcdev);
> -		if (ret)
> -			goto out_free;
> -	}
> +	ret = virtio_ccw_set_transport_rev(vcdev);
> +	if (ret)
> +		goto out_free;
> 
>  	ret = register_virtio_device(&vcdev->vdev);
>  	if (ret) {
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/