linux-kernel - Re: [PATCH] pps: Add support for read operations and return a useful value in poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABkLObpPWs_EZKtVhFHpR7QsZ0WgxeCWMVT4qA_i-AOuCb=4ew@mail.gmail.com>
Date:	Wed, 1 Apr 2015 13:56:33 +0200
From:	Christian Riesch <christian.riesch@...cron.at>
To:	Christian Riesch <christian.riesch@...cron.at>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pps: Add support for read operations and return a useful
 value in poll

Hi Rodolfo,

Thanks for your reply!

On Wed, Apr 1, 2015 at 10:11 AM, Rodolfo Giometti <giometti@...eenne.com> wrote:
> On Tue, Mar 31, 2015 at 11:31:22PM +0200, Christian Riesch wrote:
>> The PPS_FETCH ioctl in drivers/pps/pps.c blocks until a new PPS event
>> occurs, then returns the time stamp data. While this is fine for
>> lots of applications, sometimes it would be nice if the poll system
>> call and a subsequent read could be used to obtain the pps data.
>
> Nak. The read syscall can't be forced to return fix amount of
> data.

I just copied/modified the behavior of ptp_read() in drivers/ptp/ptp_chardev.c:

if (cnt % sizeof(struct ptp_extts_event) != 0)
        return -EINVAL;

There the amount of data is forced to be a multiple of sizeof(struct
ptp_extts_event). But if you prefer an ioctl, I can change that of
course.

>
> Use a dedicated ioctl instead.

Is it ok to pair POLLIN | POLLRDNORM in the poll function with an
ioctl? Or should returning POLLIN | POLLRDNORM mean that a read() will
not block? Should I use POLLPRI instead or something else?

Regards, Christian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/