linux-kernel - Re: [PATCH 2/4] perf tools: introduce machine_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150401121853.GB10820@krava.brq.redhat.com>
Date:	Wed, 1 Apr 2015 14:18:53 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	acme@...nel.org, jolsa@...nel.org, namhyung@...nel.org,
	mingo@...hat.com, lizefan@...wei.com, pi3orama@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] perf tools: introduce machine_map_new to merge
 mmap/mmap2 processing code.

On Wed, Apr 01, 2015 at 10:33:13AM +0000, Wang Nan wrote:
> Create a machine_map_new() and merge mapping code in
> machine__process_mmap2_event() and machine__process_mmap_event()
> together. This patch is a preparation for following map adjustment
> patches.
> 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> ---
>  tools/perf/util/machine.c | 30 +++++++++++++++++++++---------
>  1 file changed, 21 insertions(+), 9 deletions(-)
> 
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index e335330..051883a 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -1155,13 +1155,29 @@ out_problem:
>  	return -1;
>  }
>  
> +static int machine_map_new(struct machine *machine, u64 start, u64 len,
> +		     u64 pgoff, u32 pid, u32 d_maj, u32 d_min, u64 ino,
> +		     u64 ino_gen, u32 prot, u32 flags, char *filename,
> +		     enum map_type type, struct thread *thread)

the name style for this should be more like 'machine__new_map'
I think Arnaldo will chime in.. ;-)

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/