linux-kernel - Re: [PATCH] perf: unwind: fix segbase for libunwind.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150401144839.GA17340@gmail.com>
Date:	Wed, 1 Apr 2015 16:48:39 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	acme@...nel.org, jolsa@...nel.org, namhyung@...nel.org,
	mingo@...hat.com, lizefan@...wei.com, pi3orama@....com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: unwind: fix segbase for libunwind.


* Wang Nan <wangnan0@...wei.com> wrote:

> Perf passes incorrect segbase and table_data to libunwind when 
> map->pgoff != 0, causes unwind failure. This patch fixes this 
> problem.
> 
> segbase is an absolute offset from the head of object file, directly 
> read from ELF file. Original code computes corresponding virtual 
> address using map->start + segbase, doesn't consider map->pgoff. 
> Which causes libunwind read from incorrect offset.

What's the effect of this bug in practice?

Is there any before/after output you can show that demonstrates the 
fix?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/