linux-kernel - Re: [PATCH] fs: btrfs: Add missing include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427918598.20109.1@mail.thefacebook.com>
Date:	Wed, 1 Apr 2015 16:03:18 -0400
From:	Chris Mason <clm@...com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Josef Bacik <jbacik@...com>, David Sterba <dsterba@...e.cz>,
	<linux-btrfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] fs: btrfs: Add missing include file

On Wed, Apr 1, 2015 at 3:58 PM, Guenter Roeck <linux@...ck-us.net> 
wrote:
> On 04/01/2015 12:28 PM, Chris Mason wrote:
>> On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck <linux@...ck-us.net> 
>> wrote:
>>> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote:
>>>>  Building alpha:allmodconfig fails with
>>>> 
>>>>  fs/btrfs/inode.c: In function 'check_direct_Excellent idea. 
>>>> Done,IO':
>>>>  fs/btrfs/inode.c:8050:2: error: implicit declaration of function 
>>>> 'iov_iter_alignment'
>>>> 
>>>>  due to a missing include file.
>>>> 
>>>>  Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h")
>>>>  Cc: Christoph Hellwig <hch@....de>
>>>>  Signed-off-by: Guenter Roeck <linux@...ck-us.net>
>>>>  ---
>>> 
>>> This problem still affects the following builds as of today.
>>> 
>>> alpha:allmodconfig
>>> i386:allyesconfig
>>> i386:allmodconfig
>>> m68k:allmodconfig
>>> mips:allmodconfig
>>> xtensa:allmodconfig
>>> 
>>> and thus probabably many other allmodconfig builds which I don't 
>>> try to build.
>>> 
>>> This is getting really annoying, and prevents us from finding and 
>>> fixing
>>> other build problems.
>>> 
>>> It has been more than two weeks since I submitted the patch. This 
>>> suggests
>>> that the patch got lost otr that the Powers That Be don't care. 
>>> Which one
>>> is it ?
>>> 
>>> Should I request to revert 3737c63e1fb0 instead ?
>> 
>> I'll put the include into my branch for -next, thanks!
>> 
> 
> I have not seen the problem in the latest -next build,
> which presumably means that some other patch must have
> fixed the problem or at least hides it now. No idea
> which one, though.

It's not immediately obvious what might have fixed it, so I'll keep 
this patch in my -next for today at least ;)

-chris



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/