linux-kernel - Re: [PATCH] checkpatch/SubmittingPatches: Suggest line wrapping commit messages at 72 columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150401131824.efafdf9c97188f97cb4a212c@linux-foundation.org>
Date:	Wed, 1 Apr 2015 13:18:24 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Jonathan Corbet <corbet@....net>,
	David Miller <davem@...emloft.net>,
	Ian Morris <ipm@...rality.org.uk>, netdev@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	linux-doc <linux-doc@...r.kernel.org>
Subject: Re: [PATCH] checkpatch/SubmittingPatches: Suggest line wrapping
 commit messages at 72 columns

On Wed, 01 Apr 2015 13:09:29 -0700 Joe Perches <joe@...ches.com> wrote:

> On Wed, 2015-04-01 at 21:36 +0200, Jonathan Corbet wrote:
> > On Wed, 1 Apr 2015 12:20:01 -0700
> > Andrew Morton <akpm@...ux-foundation.org> wrote:
> > > waah, I use 75 and this patch has ruined my life.
> 
> crybaby... :)

I'm very sensitive.

> > I use 75 too, FWIW.
> > 
> > It seems to me that nobody out there complains about 75-character lines
> > in commit logs; it's the 120-character lines that irritate people.  I
> > would suggest that this limit could be set to 75 (or even, say, 77)
> 
> 77 might be one too many.
> 
> git log has a default 4 space indent of the commit message so
> 75 or 76 would still fit an 80 column screen.

That's a good point.  Good enough to be in a changelog ;)

76 sounds a bit risky - I don't think I trust every output device to
dtrt with 80-column text.  I might be wrong about that.  75 would save
my handkerchiefs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/