linux-kernel - Re: [PATCH 2/2] phy: Add driver for Pistachio USB2.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427920728.31790.94.camel@perches.com>
Date:	Wed, 01 Apr 2015 13:38:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Andrew Bresticker <abrestic@...omium.org>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Ralf Baechle <ralf@...ux-mips.org>, devicetree@...r.kernel.org,
	linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
	James Hartley <james.hartley@...tec.com>,
	Damien Horsley <Damien.Horsley@...tec.com>
Subject: Re: [PATCH 2/2] phy: Add driver for Pistachio USB2.0 PHY

On Wed, 2015-04-01 at 13:16 -0700, Andrew Bresticker wrote:
> Add a driver for the USB2.0 PHY found on the IMG Pistachio SoC.

Spelling trivia:

> diff --git a/drivers/phy/phy-pistachio-usb.c b/drivers/phy/phy-pistachio-usb.c
[]
> +static int pistachio_usb_phy_power_on(struct phy *phy)
> +{
[]
> +	if (p_phy->refclk == REFCLK_XO_CRYSTAL && rate != 12000000) {
> +		dev_err(p_phy->dev, "Unspported rate for XO crystal: %ld\n",

typo

[]

> +	if (i == ARRAY_SIZE(fsel_rate_map)) {
> +		dev_err(p_phy->dev, "Unspported clock rate: %lu\n", rate);

here too


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/