linux-kernel - Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150401030124.GO3849@piout.net>
Date:	Wed, 1 Apr 2015 05:01:24 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Aaro Koskinen <aaro.koskinen@....fi>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

On 28/03/2015 at 23:09:36 +0200, Aaro Koskinen wrote :
> Use function name in the error log instead of __FILE__.
> 
> Signed-off-by: Aaro Koskinen <aaro.koskinen@....fi>
Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

> ---
>  drivers/rtc/hctosys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/hctosys.c b/drivers/rtc/hctosys.c
> index 6c719f2..7748a61 100644
> --- a/drivers/rtc/hctosys.c
> +++ b/drivers/rtc/hctosys.c
> @@ -33,7 +33,7 @@ static int __init rtc_hctosys(void)
>  
>  	if (rtc == NULL) {
>  		pr_err("%s: unable to open rtc device (%s)\n",
> -			__FILE__, CONFIG_RTC_HCTOSYS_DEVICE);
> +			__func__, CONFIG_RTC_HCTOSYS_DEVICE);
>  		goto err_open;
>  	}
>  
> -- 
> 2.2.0
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/