linux-kernel - Re: [PATCH v3] x86, earlyprintk: Fix two 'defined but not used' compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150402043538.GB3483@pd.tnic>
Date:	Thu, 2 Apr 2015 06:35:39 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Mark Einon <mark.einon@...il.com>
Cc:	x86@...nel.org, tglx@...utronix.de, mingo@...nel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com,
	stuart.r.anderson@...el.com
Subject: Re: [PATCH v3] x86, earlyprintk: Fix two 'defined but not used'
 compile warnings

On Wed, Apr 01, 2015 at 10:32:04PM +0100, Mark Einon wrote:
> Two static functions are only used if CONFIG_PCI is defined,so only build them
> if this is the case. Fixes the build warnings:
> 
> arch/x86/kernel/early_printk.c:98:13: warning: ‘mem32_serial_out’ defined but not used [-Wunused-function]
>  static void mem32_serial_out(unsigned long addr, int offset, int value)
>              ^
> arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but not used [-Wunused-function]
>  static unsigned int mem32_serial_in(unsigned long addr, int offset)
>                      ^
> 
> Also convert a few related instances of uintXX_t to kernel specific uXX defines.
> 
> Signed-off-by: Mark Einon <mark.einon@...il.com>
> ---
> v2 - Move code to another #ifdef instead of creating a new ifdef pair after
> comment by Borislav Petkov <bp@...en8.de>.
> 
> v3 - Fixed commit errors from v2, changed some uintXX_t data types to equivalent uXX.
> 
>  arch/x86/kernel/early_printk.c | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/