linux-kernel - Re: [PATCH] perf: annotate: make it respect -i option.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Apr 2015 17:12:31 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	acme@...nel.org, jolsa@...nel.org, mingo@...hat.com,
	lizefan@...wei.com, pi3orama@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: annotate: make it respect -i option.

On Thu, Apr 02, 2015 at 06:04:52AM +0000, Wang Nan wrote:
> There is a bug in perf annotate that it doesn't respect user provided
> '-i'/'--input' option:
> 
>  # perf record ls
>    [ perf record: Woken up 1 times to write data ]
>    [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ]
>  # mv ./perf.data ./perf.data.new
>  # perf annotate -i ./perf.data.new  --stdio
>    failed to open perf.data: No such file or directory  (try 'perf record' first)
> 
> This patch fix it by setting file path after option parsing, like
> what 'perf report' does.
> 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>

I guess other commands are also suffered from this bug.. anyway,

Acked-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/