| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <551C9E71.9010305@roeck-us.net> Date: Wed, 01 Apr 2015 18:42:09 -0700 From: Guenter Roeck <linux@...ck-us.net> To: James Hogan <james.hogan@...tec.com>, Andrew Bresticker <abrestic@...omium.org> CC: Wim Van Sebroeck <wim@...ana.be>, linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org, Ezequiel Garcia <ezequiel.garcia@...tec.com> Subject: Re: [PATCH V2 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree On 04/01/2015 03:22 PM, James Hogan wrote: > Hi Andrew, > > On Wed, Apr 01, 2015 at 10:43:14AM -0700, Andrew Bresticker wrote: >> Since the heartbeat is statically initialized to its default value, >> watchdog_init_timeout() will never look in the device-tree for a >> timeout-sec value. Instead of statically initializing heartbeat, >> fall back to the default timeout value if watchdog_init_timeout() >> fails. > > Whoops. Sorry about that. I wasn't aware that a timeout-sec value was > expected. It isn't mentioned in the DT binding documentation for this > device :-(. > Hi James, This is a standard watchdog driver attribute. See Documentation/watchdog/watchdog-kernel-api.txt. [ Agreed, it would probably make sense to document that in the bindings. ] Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists