linux-kernel - Re: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150402105453.GC9447@x1>
Date:	Thu, 2 Apr 2015 11:54:53 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	"Pallala, Ramakrishna" <ramakrishna.pallala@...el.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Carlo Caione <carlo@...one.org>,
	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Subject: Re: [PATCH v1 1/2] mfd/axp20x: add support for extcon cell

On Thu, 02 Apr 2015, Pallala, Ramakrishna wrote:

> Hi,
> 
> > > diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> > > index dfabd6d..4ed8071 100644
> > > --- a/include/linux/mfd/axp20x.h
> > > +++ b/include/linux/mfd/axp20x.h
> > > @@ -275,4 +275,9 @@ struct axp20x_fg_pdata {
> > >  	int thermistor_curve[MAX_THERM_CURVE_SIZE][2];
> > >  };
> > >
> > > +struct axp288_extcon_pdata {
> > > +	/* GPIO pin control to switch D+/D- lines b/w PMIC and SOC */
> > > +	struct gpio_desc *gpio_mux_cntl;
> > > +};
> > 
> > This chunk of code is unrelated to this patch.
> As it's axp20x.h file change I added it here...if you don’t feel logical to have it in the patch I can move this to patch 2/2.

You should add it to the patch that first uses it.

> > ... and does it need to be in a struct of its own?
> Yes, I am planning to add another gpio control for VBUS boost.

Okay, thanks for clarifying.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/