linux-kernel - Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551D265C.40703@nokia.com>
Date:	Thu, 02 Apr 2015 13:22:04 +0200
From:	Alexander Sverdlin <alexander.sverdlin@...ia.com>
To:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
CC:	Ioan Nicu <ioan.nicu.ext@...ia.com>,
	Peter Korsgaard <peter.korsgaard@...co.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Mathias Rulf <mathias.rulf@...ia.com>
Subject: Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe
 deferrals

On 30/03/15 15:03, Ioan Nicu wrote:
> Probe deferral is not an error case. It happens only when
> the necessary dependencies are not there yet.
> 
> The driver core is already printing a message when a driver
> requests probe deferral, so this can be traced in the logs
> without these error prints.
> 
> This patch removes the error messages for these deferral cases.
> 
> Signed-off-by: Ionut Nicu <ioan.nicu.ext@...ia.com>

Acked-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index f5798eb..70db992 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux,
>  		return -ENODEV;
>  	}
>  	adapter = of_find_i2c_adapter_by_node(adapter_np);
> -	if (!adapter) {
> -		dev_err(&pdev->dev, "Cannot find parent bus\n");
> +	if (!adapter)
>  		return -EPROBE_DEFER;
> -	}
> +
>  	mux->data.parent = i2c_adapter_id(adapter);
>  	put_device(&adapter->dev);
>  
> @@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  	}
>  
>  	parent = i2c_get_adapter(mux->data.parent);
> -	if (!parent) {
> -		dev_err(&pdev->dev, "Parent adapter (%d) not found\n",
> -			mux->data.parent);
> +	if (!parent)
>  		return -EPROBE_DEFER;
> -	}
>  
>  	mux->parent = parent;
>  	mux->gpio_base = gpio_base;
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/