linux-kernel - Re: [PATCH v2] xen-blkback: define pr_fmt macro to avoid the duplication of DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <551D2BE9.2000002@citrix.com>
Date:	Thu, 2 Apr 2015 13:45:45 +0200
From:	Roger Pau Monné <roger.pau@...rix.com>
To:	"Chentao (Boby)" <boby.chen@...wei.com>, <konrad.wilk@...cle.com>,
	<joe@...ches.com>
CC:	<xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>,
	<wu.wubin@...wei.com>, <rudy.zhangmin@...wei.com>
Subject: Re: [PATCH v2] xen-blkback: define pr_fmt macro to avoid the duplication
 of DRV_PFX

El 02/04/15 a les 3.32, Chentao (Boby) ha escrit:
> 
> 
> On 2015/4/1 23:04, Tao Chen wrote:
>> Define pr_fmt macro with {xen-blkback: } prefix, then remove all use
>> of DRV_PFX in the pr sentences. Replace all DPRINTK with pr sentences,
>> and get rid of DPRINTK macro. It will simplify the code.
>>
>> And if the pr sentences miss a \n, add it in the end. If the DPRINTK
>> sentences have redundant \n, remove it. It will format the code.
>>
> 
> I'm sorry, I made a mistake in this patch log. It must be changed as below.
> 
> And if the pr sentences miss a \n, add it in the end. It will format the
> code.
> 
> I apologize for the disturb of wrong patch log. Very looking forward
> to your reply.
> 
>> These all make the readability of the code become better.
>>
>> Signed-off-by: Tao Chen <boby.chen@...wei.com>

Thanks, with the commit message amended:

Acked-by: Roger Pau Monné <roger.pau@...rix.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/