linux-kernel - Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Apr 2015 09:49:34 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [RFC][PATCH 01/17 v2] tracing: Add TRACE_SYSTEM_VAR to
 intel-sst

On Thu, 2 Apr 2015 14:40:33 +0100
Mark Brown <broonie@...nel.org> wrote:

> On Thu, Apr 02, 2015 at 09:33:41AM -0400, Steven Rostedt wrote:
> > Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > > I couldn't find anything in MAINTAINERS about that file, but I didn't
> > > look for your name though.
> 
> > BTW, was that considered an Acked-by?
> 
> I guess, you probably want to ping the Intel guys though since it's them
> that would be affected by the interface change.

Actually, there's no interface change. This is the work-around patch to
that. It's only internal to the kernel and userspace does not see any
difference.

I just needed a unique TRACE_SYSTEM name that was also a valid C
variable, and now use TRACE_SYSTEM_VAR.

The ftrace code now has:

#ifndef TRACE_SYSTEM_VAR
#define TRACE_SYSTEM_VAR TRACE_SYSTEM
#endif

And this allows trace headers (like intel-sst.h) to have a different
VAR variable from the TRACE_SYSTEM name:

#define TRACE_SYSTEM intel-ssl

#define TRACE_SYSTEM_VAR intel_ssl

This lets me use something that will work and not need to change what
the user space sees.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/