linux-kernel - Re: [PATCH v2.1] ftracetest: Do not use usleep directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Apr 2015 08:20:09 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
CC:	Namhyung Kim <namhyung@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Pádraig Brady <P@...igBrady.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Dave Jones <davej@...emonkey.org.uk>,
	Luis Henriques <luis.henriques@...onical.com>,
	Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH v2.1] ftracetest: Do not use usleep directly

On 04/02/2015 07:38 AM, Steven Rostedt wrote:
> On Thu, 02 Apr 2015 14:58:04 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:
> 
>> (2015/04/02 13:34), Namhyung Kim wrote:
>>> The usleep is only provided on distros from Redhat so running ftracetest
>>> on other distro resulted in failures due to the missing usleep.
>>>
>>> The reason of using [u]sleep in the test was to generate (scheduler)
>>> events.  It can be done various ways like this:
>>>
>>> yield() {  ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1; }
>>
>> Nice hack! :)
> 
> Yep, it was Pádraig Brady's idea.
> 
>>
>> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> 
> Acked-by: Steven Rostedt <rostedt@...dmis.org>
> 
> -- Steve
> 
>>
>>>
>>> Reported-by: Michael Ellerman <mpe@...erman.id.au>
>>> Reported-by: Dave Jones <davej@...emonkey.org.uk>
>>> Reported-by: Luis Henriques <luis.henriques@...onical.com>
>>> Based-on-patch-by: Pádraig Brady <P@...igBrady.com>

Is this standard? checkpatch complained as non-standard. I am
seeing some patches posted with Based-on-patch-by

Anyway, I have this patch tagged for 4.1-rc2

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@....samsung.com | (970) 217-8978
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/