linux-kernel - userspace breakage in linux/nfsd/debug.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427985766.2973.11.camel@deneb.redhat.com>
Date:	Thu, 02 Apr 2015 10:42:46 -0400
From:	Mark Salter <msalter@...hat.com>
To:	Jeff Layton <jlayton@...marydata.com>
Cc:	Trond Myklebust <trond.myklebust@...marydata.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: userspace breakage in linux/nfsd/debug.h

This patch:

  commit f895b252d4edf66b2895fb5a7b17a638665f3e1f
  Author: Jeff Layton <jlayton@...marydata.com>
  Date:   Mon Nov 17 16:58:04 2014 -0500

    sunrpc: eliminate RPC_DEBUG
    
    It's always set to whatever CONFIG_SUNRPC_DEBUG is, so just use that.
    
    Signed-off-by: Jeff Layton <jlayton@...marydata.com>
    Signed-off-by: Trond Myklebust <trond.myklebust@...marydata.com>

breaks userspace use of linux/nfsd/debug.h because of:

  diff --git a/include/uapi/linux/nfsd/debug.h b/include/uapi/linux/nfsd/debug.h
  index a6f453c..1fdc95b 100644
  --- a/include/uapi/linux/nfsd/debug.h
  +++ b/include/uapi/linux/nfsd/debug.h
  @@ -15,7 +15,7 @@
    * Enable debugging for nfsd.
    * Requires RPC_DEBUG.
    */
  -#ifdef RPC_DEBUG
  +#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
   # define NFSD_DEBUG		1
   #endif
 
IS_ENABLED() is not available outside the kernel and causes a compile
time failure:

  /usr/include/linux/nfsd/debug.h:18:15: error: missing binary operator before token "("
 #if IS_ENABLED(CONFIG_SUNRPC_DEBUG)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/