linux-kernel - Re: [PATCH perf/core v2] perf-probe: Fix to track down unnamed union/structure members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150402145732.GA11963@kernel.org>
Date:	Thu, 2 Apr 2015 11:57:32 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>, namhyung@...nel.org,
	Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH perf/core v2] perf-probe: Fix to track down unnamed
 union/structure members

Em Thu, Apr 02, 2015 at 04:33:12PM +0900, Masami Hiramatsu escreveu:
> Fix perf probe to track down unnamed union/structure members.
> perf probe did not track down the tree of unnamed union/structure
> members, since it just failed to find given "name" in a parent
> structure/union. To solve this issue, I've introduced 2 changes.
> 
> - Fix die_find_member() to track down the type-DIE if it is
>   unnamed, and if it contains the specified member, returns the
>   unnamed member.
>   (note that we don't return found member, since unnamed member
>    has the offset in the parent structure)
> - Fix convert_variable_fields() to track down the unnamed union/
>   structure (one-by-one).
> 
> With this patch, perf probe can access unnamed fields.
>   -----
>   #./perf probe -nfx ./perf lock__delete ops 'locked_ops=ops->locked.ops'
>   Added new event:
>     probe_perf:lock__delete (on lock__delete in /home/mhiramat/ksrc/linux-3/tools/perf/perf with ops locked_ops=ops->locked.ops)
> 
>   You can now use it in all perf tools, such as:
> 
>           perf record -e probe_perf:lock__delete -aR sleep 1
>   -----
> 
> The original report of this issue is: https://lkml.org/lkml/2015/3/5/431

Thanks a lot! Applied, built and tested, all works as expected,

Merged,

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/