linux-kernel - Re: [2/4] powerpc/rcpm: add RCPM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427989850.22867.266.camel@freescale.com>
Date:	Thu, 2 Apr 2015 10:50:50 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Zhao Chenhui-B35336 <chenhui.zhao@...escale.com>
CC:	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Jin Zhengxiong-R64188" <Jason.Jin@...escale.com>
Subject: Re: [2/4] powerpc/rcpm: add RCPM driver

On Thu, 2015-04-02 at 05:33 -0500, Zhao Chenhui-B35336 wrote:
> > +static int rcpm_v2_plat_enter_state(int state)
> > +{
> > +     u32 *pmcsr_reg = &rcpm_v2_regs->powmgtcsr;
> > +     int ret = 0;
> > +     int result;
> > +
> > +     switch (state) {
> > +     case PLAT_PM_LPM20:
> > +             /* clear previous LPM20 status */
> > +             setbits32(pmcsr_reg, RCPM_POWMGTCSR_P_LPM20_ST);
> 
> How would the bit be set when you enter here, given that you wait for it
> to clear when leaving?
> 
> [chenhui] Actually, the bit is not used by software. Just follow the instruction in RM.

Sorry, I missed the "_P_" and thought it was RCPM_POWMGTCSR_LPM20_ST.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/