linux-kernel - Re: [PATCH] watchdog: nohz: don't run watchdog on nohz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150402160833.GH175361@redhat.com>
Date:	Thu, 2 Apr 2015 12:08:33 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Chris Metcalf <cmetcalf@...hip.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andrew Jones <drjones@...hat.com>,
	chai wen <chaiw.fnst@...fujitsu.com>,
	Ulrich Obergfell <uobergfe@...hat.com>,
	Fabian Frederick <fabf@...net.be>,
	Aaron Tomlin <atomlin@...hat.com>,
	Ben Zhang <benzh@...omium.org>,
	Christoph Lameter <cl@...ux.com>,
	Gilad Ben-Yossef <gilad@...yossef.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] watchdog: nohz: don't run watchdog on nohz_full cores

On Thu, Apr 02, 2015 at 11:42:43AM -0400, Chris Metcalf wrote:
> >
> >>Then perhaps as a debug aid, expose a /proc/sys/kernel/watchdog_cpumask for
> >>folks to modify in case they want to enable the watchdog on the nohz cpus.
> >That sounds like a good idea.
> 
> OK, I will respin v2 of the patch as follows:
> 
> - Provide a watchdog_cpumask as suggested by Don.
> - On a non-NO_HZ_FULL build, it defaults to cpu_possible as normal
> - On a NO_HZ_FULL build, it defaults to the housekeeping cpus
> - If the mask is modified, we disable and then re-enable the watchdog,
>   so that the watchdog init code can exit() the appropriate threads as
>   they start up

Sounds good. :-)

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/