linux-kernel - Re: [PATCH RESEND] efivarfs: Ensure VariableName is NUL-terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427999332.7230.12.camel@srcf.ucam.org>
Date:	Thu, 02 Apr 2015 11:28:52 -0700
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Ross Lagerwall <ross.lagerwall@...rix.com>
Cc:	linux-efi@...r.kernel.org, Jeremy Kerr <jk@...abs.org>,
	Matt Fleming <matt.fleming@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] efivarfs: Ensure VariableName is NUL-terminated

On Thu, 2015-04-02 at 08:39 +0100, Ross Lagerwall wrote:
> Some buggy firmware implementations update VariableNameSize on success
> such that it does not include the final NUL character which results in
> garbage in the efivarfs name entries.  Use kzalloc on the efivar_entry
> (as is done in efivars.c) to ensure that the name is always
> NUL-terminated.
> 
> The buggy firmware is:
> BIOS Information
>         Vendor: Intel Corp.
>         Version: S1200RP.86B.02.02.0005.102320140911
>         Release Date: 10/23/2014
>         BIOS Revision: 4.6
> System Information
>         Manufacturer: Intel Corporation
>         Product Name: S1200RP_SE
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>
ACKed-by: Matthew Garrett <mjg59@...eos.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/