linux-kernel - Re: kernel/timer: avoid spurious ksoftirqd wakeups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150402202954.GA8957@amt.cnet>
Date:	Thu, 2 Apr 2015 17:29:54 -0300
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
Cc:	"'Luiz Capitulino'" <lcapitulino@...hat.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: kernel/timer: avoid spurious ksoftirqd wakeups

On Thu, Apr 02, 2015 at 11:32:49AM +0800, Hillf Danton wrote:
> > --- a/kernel/time/tick-sched.c
> > +++ b/kernel/time/tick-sched.c
> > @@ -568,6 +568,7 @@ static ktime_t tick_nohz_stop_sched_tick(struct tick_sched *ts,
> >  	unsigned long rcu_delta_jiffies;
> >  	struct clock_event_device *dev = __this_cpu_read(tick_cpu_device.evtdev);
> >  	u64 time_delta;
> > +	bool raise_softirq;
> > 
> s/raise_softirq/raise_softirq = false/ ?

Not necessary, variable is initialized before being used.

> >  	time_delta = timekeeping_max_deferment();
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/