linux-kernel - Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551E52BC.3040702@atmel.com>
Date:	Fri, 3 Apr 2015 10:43:40 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	<linux-arm-kernel@...ts.infradead.org>,
	Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
	Kevin Hilman <khilman@...nel.org>,
	"ARM Maintainers" <arm@...nel.org>
CC:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Boris BREZILLON <boris.brezillon@...e-electrons.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Johan Hovold <johan@...nel.org>, <stable@...r.kernel.org>
Subject: Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1

Le 31/03/2015 10:56, Nicolas Ferre a écrit :
> After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091)
> the macb1 interface refuses to work properly because it tries
> to cling to address 0 which isn't able to communicate in broadcast with
> the mac anymore. The micrel phy on the board is actually configured
> to show up at address 1.
> Adding the phy node and its real address fixes the issue.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
> Cc: Johan Hovold <johan@...nel.org>
> Cc: <stable@...r.kernel.org> #3.19
> ---

Arnd, Olof, Kevin,

It seems late but, is it possible to queue this patch as a 4.0 fixes?

Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used
by u-boot previously.

Bye,

>  arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> index fec1fca2ad66..6c4bc53cbf4e 100644
> --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts
> @@ -167,7 +167,13 @@
>  
>  			macb1: ethernet@...2c000 {
>  				phy-mode = "rmii";
> +				#address-cells = <1>;
> +				#size-cells = <0>;
>  				status = "okay";
> +
> +				ethernet-phy@1 {
> +					reg = <0x1>;
> +				};
>  			};
>  
>  			dbgu: serial@...fee00 {
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/