linux-kernel - Re: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150403134042.GA31251@kroah.com>
Date:	Fri, 3 Apr 2015 15:40:42 +0200
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	"Dhere, Chaitanya (C.)" <cvijaydh@...teon.com>
Cc:	"navin.patidar@...il.com" <navin.patidar@...il.com>,
	"vthakkar1994@...il.com" <vthakkar1994@...il.com>,
	"tapaswenipathak@...il.com" <tapaswenipathak@...il.com>,
	"dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
	"abelmoyo.ab@...il.com" <abelmoyo.ab@...il.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy
 combination with kmemdup

On Mon, Mar 30, 2015 at 03:11:25PM +0000, Dhere, Chaitanya (C.) wrote:
> This change was detected with the help of coccinelle tool.
> It performs the same function as kzalloc amd memcpy.
> 
> Signed-off-by: Chaitanya Dhere <cvijaydh@...teon.com>

Your From: line and this line don't match :(

> ---
>  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> index 86d955f..07ae6cf 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
> @@ -5431,15 +5431,14 @@ u8 set_tx_beacon_cmd(struct adapter *padapter)
>  		goto exit;
>  	}
>  
> -	ptxBeacon_parm = kzalloc(sizeof(struct wlan_bssid_ex), GFP_KERNEL);
> +	ptxBeacon_parm = kmemdup(&(pmlmeinfo->network),
> +				 sizeof(struct wlan_bssid_ex), GFP_KERNEL);
>  	if (ptxBeacon_parm == NULL) {
>  		kfree(ph2c);
>  		res = _FAIL;
>  		goto exit;
>  	}
>  
> -	memcpy(ptxBeacon_parm, &(pmlmeinfo->network), sizeof(struct wlan_bssid_ex));
> -
>  	len_diff = update_hidden_ssid(ptxBeacon_parm->IEs+_BEACON_IE_OFFSET_,
>  				      ptxBeacon_parm->IELength-_BEACON_IE_OFFSET_,
>  				      pmlmeinfo->hidden_ssid_mode);
> -- 
> 1.9.1

This patch fails to apply for some odd reason, the patch seems
corrupted.  Please look into your email client settings and try it
again.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/