linux-kernel - Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5yK5F-KoUSgraDiD=DDjH9CEGz2V=yKO8uA6G8-A4GNoeLgw@mail.gmail.com>
Date:	Fri, 3 Apr 2015 22:33:17 +0530
From:	Amitoj Kaur Chawla <amitoj1606@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

On Fri, Apr 3, 2015 at 10:21 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
>
> On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote:
> > Removes variable comparison with 0 by using !.
>
> Sometimes testing for zero makes sense.  When you write code, you are
> telling a story.  If you are talking about zero as a number then it
> can make sense.  If it's zero as a boolean then it doesn't make sense.
>
> Also strcmp() and similar should always be done as == 0, < 0 or != 0
> because that is the idiom:
>
>         if name != "foo" then
>
> becomes:
>
>         if (strcmpt(name, "foo") != 0) {
>
> The != from the first is shifted in the second.
>
> So I don't really think this approach is the right thing.  You have to
> read the code and understand the story it is telling.  Then change it
> if needed.
>

Thank you for the advice! I will look into it!

-- 
Regards,

Amitoj Kaur Chawla
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/