linux-kernel - Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 3 Apr 2015 19:05:59 +0200
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nicholas Krause <xerofoify@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>, seanm@...nm.ca,
	devel@...verdev.osuosl.org, mdcasey@...bloom.com,
	aysemelikeyurtoglu@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:rtl8192e: Change printk statements in
 rtllib_tx.c to use netdev_dev

On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote:
> 
> 
> On April 3, 2015 5:19:55 AM EDT, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> >
> >> @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct
> >net_device *dev)
> >>  	   IEEE_SOFTMAC_TX_QUEUE)) ||
> >>  	   ((!ieee->softmac_data_hard_start_xmit &&
> >>  	   (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) {
> >> -		printk(KERN_WARNING "%s: No xmit handler.\n",
> >> +		netdev_info(ieee->dev, "%s: No xmit handler.\n",
> >
> >
> >This should be netdev_warn().  There are a few other similar places.
> >
> >regards,
> >dan carpenter
> My bad will send in a v2 fixing this. 

Please don't, I'm not going to be taking patches from you any _year_
soon.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/