linux-kernel - Re: [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvyp14EssrYK+ZBvVtsh=m8kzW1OPL=qicRTYw+4QgUgQA@mail.gmail.com>
Date:	Sat, 4 Apr 2015 00:03:38 +0200
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	Chen Gang <xili_gchen_5257@...mail.com>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb: musb: Kconfig: Depend on some machines under blackfin

On Fri, Apr 3, 2015 at 11:51 PM, Chen Gang <xili_gchen_5257@...mail.com> wrote:
> Under blackfin, only bf527, bf548 and bf609 may use musb. The related
> error with allmodconfig:
>
>     CC [M]  drivers/usb/misc/trancevibrator.o
>   In file included from drivers/usb/musb/musb_core.h:70:0,
>                    from drivers/usb/musb/musb_core.c:103:
>   drivers/usb/musb/musb_core.c: In function 'musb_indexed_ep_select':
>   drivers/usb/musb/musb_regs.h:458:32: error: 'USB_INDEX' undeclared (first use in this function)
>    #define MUSB_INDEX  USB_OFFSET(USB_INDEX) /* 8 bit */
>                                   ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
> ---
>  drivers/usb/musb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> index 39db8b6..5fca898 100644
> --- a/drivers/usb/musb/Kconfig
> +++ b/drivers/usb/musb/Kconfig
> @@ -6,7 +6,7 @@
>  # (M)HDRC = (Multipoint) Highspeed Dual-Role Controller
>  config USB_MUSB_HDRC
>         tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
> -       depends on (USB || USB_GADGET)
> +       depends on (USB || USB_GADGET) && (!BLACKFIN || (BLACKFIN && (BF527 || BF548 || BF609)))

This is ugly.
Can't you add a new Kconfig symbol in arch/blackfin and change the
#ifndef CONFIG_BLACKFIN
in drivers/usb/musb/musb_regs.h to it?

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/