lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 2 Apr 2015 22:53:38 -0400 From: Nickolaus Woodruff <nickolauswoodruff@...il.com> To: wsa@...-dreams.de Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] drivers/i2c/i2c-core.c: Fix sparse warning This patch fixes the following sparse warning in drivers/i2c/: CHECK drivers/i2c/i2c-core.c drivers/i2c/i2c-core.c:2353:36: warning: dubious: x | !y Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@...il.com> --- drivers/i2c/i2c-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index edf274c..f50d46e 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -2350,7 +2350,7 @@ static u8 i2c_smbus_pec(u8 crc, u8 *p, size_t count) static u8 i2c_smbus_msg_pec(u8 pec, struct i2c_msg *msg) { /* The address will be sent first */ - u8 addr = (msg->addr << 1) | !!(msg->flags & I2C_M_RD); + u8 addr = (msg->addr << 1) | ((msg->flags & I2C_M_RD) != 0); pec = i2c_smbus_pec(pec, &addr, 1); /* The data buffer follows */ -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists