lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 04 Apr 2015 08:52:21 -0700 From: Joe Perches <joe@...ches.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: devel@...verdev.osuosl.org, gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value On Sat, 2015-04-04 at 16:58 +0300, Dan Carpenter wrote: > On Sat, Apr 04, 2015 at 12:04:59AM +0300, Dan Carpenter wrote: > > 1) It's more clear when read in English. "if not strcmp then" or > > "if strcmp NOT EQUAL zero". > Oops. I got that reversed. I meant "if strcmp then". Only serves to > emphasize my point though. :) When I read it I understood what you meant, but I thought the point was everybody makes mistakes. !strcmp to test equality is still pretty idiomatic. !memcmp too. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists