lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 4 Apr 2015 22:31:26 +0300 (EEST) From: Giedrius Statkevičius <giedrius.statkevicius@...il.com> To: Nickolaus Woodruff <nickolauswoodruff@...il.com> cc: sudipmmukherjee@...il.com, teddywang@...iconmotion.com, gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: sm7xxfb: Fix sparse warning On Sat, 4 Apr 2015, Nickolaus Woodruff wrote: > This patch fixes the following sparse warning in sm7xx.h: > > drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode' > was not declared. Should it be static? > > Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@...il.com> > --- > drivers/staging/sm7xxfb/sm7xx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h > index 7cc1896..c5d6253 100644 > --- a/drivers/staging/sm7xxfb/sm7xx.h > +++ b/drivers/staging/sm7xxfb/sm7xx.h > @@ -119,7 +119,7 @@ struct ModeInit { > /********************************************************************** > SM712 Mode table. > **********************************************************************/ > -struct ModeInit vgamode[] = { > +static struct ModeInit vgamode[] = { Someone already fixed this: https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/tree/drivers/staging/sm7xxfb/sm7xx.h?h=staging-testing#n122 Please work against staging-testing branch of the staging tree. Su pagarba / Regards, Giedrius -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists