lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 04 Apr 2015 14:49:45 -0700 From: Florian Fainelli <f.fainelli@...il.com> To: Pavel Nakonechny <pavel.nakonechny@...tlab.ru>, netdev@...r.kernel.org, Joe Perches <joe@...ches.com> CC: "David S. Miller" <davem@...emloft.net>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] net: dsa: fix filling routing table from OF description Le 04/04/2015 14:46, Pavel Nakonechny a écrit : > According to description in 'include/net/dsa.h', in cascade switches > configurations where there are more than one interconnected devices, > 'rtable' array in 'dsa_chip_data' structure is used to indicate which > port on this switch should be used to send packets to that are destined > for corresponding switch. > > However, dsa_of_setup_routing_table() fills 'rtable' with port numbers > of the _target_ switch, but not current one. > > This commit removes redundant devicetree parsing and adds needed port > number as a function argument. So dsa_of_setup_routing_table() now just > looks for target switch number by parsing parent of 'link' device node. > > To remove possible misunderstandings with the way of determining target > switch number, a corresponding comment was added to the source code and > to the DSA device tree bindings documentation file. > > This was tested on a custom board with two Marvell 88E6095 switches with > following corresponding routing tables: { -1, 10 } and { 8, -1 }. > > Signed-off-by: Pavel Nakonechny <pavel.nakonechny@...tlab.ru> > Reviewed-by: Andrew Lunn <andrew@...n.ch> Reviewed-by: Florian Fainelli <f.fainelli@...il.com> -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists